search

pbs-assess / gfiphc

:fishing_pole_and_fish: An R package for data extraction and analysis of groundfish data from the IPHC Longline Survey in British Columbia
3 stars 0 forks source link

Check usability codes for IPHC data are the same as other surveys #11

Open andrew-edwards opened 6 years ago

andrew-edwards commented 6 years ago

I think they are different, and will check (think I have some notes) and document somewhere.

elisekeppel commented 6 years ago

Hm, I didn’t know that – see – we need a document with all of these useful bits!

From: andrew-edwards [mailto:notifications@github.com] Sent: Wednesday, September 19, 2018 3:51 PM To: pbs-assess/gfplot Cc: Subscribed Subject: [pbs-assess/gfplot] Check usability codes for IPHC data are the same as other surveys (#35)

I think they are different, and will check (think I have some notes) and document somewhere.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/pbs-assess/gfplot/issues/35, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcE2EW3UV5vbdmQYiJkkGvUm3-VBMgEZks5ucspDgaJpZM4WxGYp.

seananderson commented 6 years ago

Ideally this document will describe many of those idiosyncrasies, but I’m sure there are all sorts of idiosyncrasies left uncovered.

If the usability codes are different then we should probably use a unique argument in the get data function since all the functions are documented together. Something like usability_iphc. And maybe list what they mean in the documentation.

seananderson commented 6 years ago 
select(
    d, species_common_name, survey_abbrev, year,
    biomass, lowerci, upperci, mean_cv,
    num_sets, num_pos_sets
  )
andrew-edwards commented 6 years ago

Above is the output form of tidy_survey_index which then gets called by plot_survey_index. Andy to get the IPHC series into that format.