search

pbs-assess / gfiphc

:fishing_pole_and_fish: An R package for data extraction and analysis of groundfish data from the IPHC Longline Survey in British Columbia
3 stars 0 forks source link

Change IPHC code to use underscores not hooksCount etc. #5

Closed andrew-edwards closed 3 years ago

seananderson commented 5 years ago

I think lintr::lint_package() will warn you about things like this to make them easy to find. If not that one then there's another package styling function I've used before.

andrew-edwards commented 5 years ago

My final results actually have things like E_it as column names (as underscores to match the math notation).

In the commit comment you mentioned it's not a huge deal for internal code - so okay for calculations within functions that don't end up being output (though I would try and make it all consistent).

seananderson commented 5 years ago

Yes, and that seems like a time when clarity of notation to match the math (the capital E) trumps the style guide.