search

pbs-assess / herringsr

:paperclip: :fish: Herring Science Response document
0 stars 1 forks source link

Adding retrospective plots to diagnostics? #3

Closed Shawkshaw closed 5 years ago

Shawkshaw commented 5 years ago

Can we add retrospective plot of spawning biomass to the diagnostic plots? like we had for the 2017 WP?

cgrandin commented 5 years ago

We can, but there is currently no retrospective loading code etc. Not hard to do but I don't see any retrospectives in the 2018 models folder. I'm trying to recall exactly how we did it. The code in HerrigAssess loads the retros, so we must have run them previously. I think I did this? Sorry for my bad memory.

Shawkshaw commented 5 years ago

Thanks Chris, I will double check with Jaclyn that they are needed with the diagnostic plots. I did the runs and plotted what I needed to look at in excel for now but if she thinks they should be included I will send you the 2019 retros and we can figure it out from there:)

cgrandin commented 5 years ago

I'll need to add the retrospective loading to the new herringutils package anyways for the assessment doc

cgrandin commented 5 years ago

I'm halfway done this. I am also adding ability to run retrospectives automatically

cgrandin commented 5 years ago

Do you have an example of the plot? I don't see the code for it, nor the figure in any document I have.. thx

Shawkshaw commented 5 years ago

image Retrospective spawning biomass for the Strait of Georgia AM2 model.

jaclyncleary commented 5 years ago

thanks on this. I will need the figure for the presentations, especially for SOG. So having it in the diagnostic plots is perfect.

cgrandin commented 5 years ago

Done. See pbs-assess/gfiscamutils@0232858c88bb99f6151be840edff62725e7959b8, pbs-assess/gfiscamutils@7113b831506df5c749034220fee9bc3d39746219, and 249f83e60851930549b2dd47962e7749d60956a0

Rebuild all packages and on first time building the document, all retrospectives will be run (50 model runs).