Clean up a few things to get rid of Warnings

pbs-assess / pacea

An R package to house Pacific Region ecosystem data to help facilitate an ecosystem approach to fisheries.

Other

14 stars 0 forks source link

Open andrew-edwards opened 5 months ago

andrew-edwards commented 5 months ago

From R-CMD-check (online, linked from checkmark next to commit), fix some Warnings:

Undocumented data sets:

[x] grid26 - @travistai2 can you do this one, I'll do the rest. This will help with #48
[ ] soi
[X] test_grid_20

Recent commit should fix this one, just a missing s in clim_anom() help:

plot_with_uncertainty_discrete:

travistai2 commented 5 months ago

I'm not sure if 'test_grid_20' was used anywhere - I didn't use it.

andrew-edwards commented 5 months ago

Yes, I think I got rid of it (hence the box was ticked). Sorry, that wasn't obvious.

andrew-edwards commented 5 months ago

[ ] Also this one https://github.com/pbs-assess/pacea/actions/runs/8841447116/job/24278561740#step:5:98 about adding ... to plot.XXX() functions. We hadn't included them because they call ggplot functions not base plot. However, I think it's okay to add them in (but not pass them onto anything), as as is done in ggplot itself (?ggplot). Trying one first to see if it changes the warning, but the warning isn't really specific about a particular function.