search

pbs-assess / pbsEDM

An R package to implement some of the methods of empirical dynamic modelling
GNU General Public License v3.0
1 stars 1 forks source link

Update documention of pbsEDM() function - X,Y,Z etc #29

Open andrew-edwards opened 2 years ago

andrew-edwards commented 2 years ago

https://github.com/luke-a-rogers/pbsEDM/blob/e7ac080aa8a142c5f1906fbb86449cf6e0399728/R/functions.R#L196

Think you updated the code really well, but the documentation is still old. I can do it (as will help me confirm what I'm doing also).

andrew-edwards commented 2 years ago

Also, I get column heading

pbs_calc2$Y
               N_t
  [1,] -0.05653141
  [2,]  0.05922378
  [3,]  5.24124928

but I think that should not be N_t. I need to check if Y can be a matrix, or is always a vector (it's always a vector in the manuscript I think, and then matrix X, which you have, has the lagged columns of it).

andrew-edwards commented 2 years ago

Though I just saw this (and checked the TODO was by you not me): https://github.com/luke-a-rogers/pbsEDM/blame/e7ac080aa8a142c5f1906fbb86449cf6e0399728/R/functions.R#L120

So is the rest of the code potentially not consistent?

andrew-edwards commented 2 years ago

Once this is sorted I will go through my two vignettes and update them for consistency.

andrew-edwards commented 2 years ago