Release sdmTMB 0.4.3 - Githubissues

pbs-assess / sdmTMB

:earth_americas: An R package for spatial and spatiotemporal GLMMs with TMB

https://pbs-assess.github.io/sdmTMB/

186 stars 26 forks source link

Release sdmTMB 0.4.3 #303

Closed seananderson closed 7 months ago

seananderson commented 7 months ago

Prepare for release:

[x] git pull
[x] Check current CRAN check results
[x] Polish NEWS
[x] urlchecker::url_check()
[x] devtools::build_readme()
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] revdepcheck::revdep_check(num_workers = 4)
[x] Update cran-comments.md
[x] git push

Submit to CRAN:

[x] usethis::use_version('patch')
[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted :tada:
[x] usethis::use_github_release()
[x] usethis::use_dev_version(push = TRUE)

seananderson commented 7 months ago

Even if no other issues get addressed, it's likely worth updating the CRAN version in the next week or two given the addition of the type argument in the delta families: 1. so the new preprint and resubmitted paper work with the CRAN version and 2. so tinyVAST can re-export the delta families from the CRAN version.

We might want to merge in the gengamma branch first.

seananderson commented 7 months ago

After just fixing this major bug, I'd like to get the next version to CRAN as soon as possible. First, I want to flesh out the tests around this issue some more.

seananderson commented 7 months ago

sdmTMB_0.4.3.tar.gz is on its way to CRAN

@James-Thorson-NOAA, this version has the delta family 'type' arguments.

James-Thorson-NOAA commented 6 months ago

Thanks Sean! I now include sdmTMB as "Imports" dependency in tinyVAST to access the family functions . However, I don't actually import delta_lognormal and delta_gamma because I want the defaults for the link functions to depend upon the type argument. tinyVAST then uses the user-specified links to transform linear predictors to the two variables in the Poisson-link delta model (N and W).

seananderson commented 6 months ago

Good point. I've made that change here: https://github.com/pbs-assess/sdmTMB/commit/fa4da5391212d49465311db5b97d2feec06ef77e and will be pushing a new version to CRAN soon since an update to glmmTMB broke a unit test comparison.

James-Thorson-NOAA commented 6 months ago

sorry to hear about the difficulty, but I'm also grateful for the change to accomodate tinyVAST :) I'll plan to Import those versions once available on CRAN. Thanks as always!