pbs / pycaption

Python module to read/write popular video caption formats
Apache License 2.0
256 stars 136 forks source link

DFXPWriter breaking xml on special character '&' from SCC input file #167

Closed kdHub closed 3 years ago

kdHub commented 6 years ago

Expected Behavior DFXP writer from scc file is valid xml output

Current Behavior DFXP writer from scc file breaks xml formatting without encoding & to &amp on 1.0.1 python3

Possible Solution https://gist.github.com/kdHub/dccae95d09e507d79d1bc8b086c3e984#file-base-py-L446

Detailed Description Appears to break Special Characters from SCC input to DFXP output. Testing these changes appears to be working as expected so far and handled by player.

http://xml.silmaril.ie/specials.html