search

pbs / pycaption

Python module to read/write popular video caption formats
Apache License 2.0
255 stars 137 forks source link

Update tests for BeautifulSoup 4.12.1 #305

Closed Vekhir closed 1 year ago

Vekhir commented 1 year ago

Starting with bs4, Tag.prettify() adds newlines to be more consistent. This breaks the tests, so they have to be updated to reflect this intended change.

Newlines were only added where necessary, i.e. in reference outputs.

Closes #304

Vekhir commented 1 year ago

@pbs @calinmarchis Is there anything I have to do to get this merged? What is the hold-up?

-- Vekhir

Vekhir commented 1 year ago

@pbs This change has been approved, but not yet merged. It fixes the tests that are currently broken. What is the timeline for merging?