pbugnion / gmaps

Google maps for Jupyter notebooks
https://jupyter-gmaps.readthedocs.io/en/stable/
Other
760 stars 147 forks source link

Allow user to draw on map in browser / produce list of coordinates #223

Closed acresnick closed 6 years ago

acresnick commented 6 years ago

Hello,

This is a great package! It's more comprehensively met my needs than any other python/google maps interface.

One additional feature that could be very useful: the ability to export an .html file, send it to someone else who can then open it up in their browser, draw on it, save it, and send it back. Is this possible?

Currently when I use a drawing layer:

1) I cannot export to .png 2) When I export to .html and open in browser, I cannot add markers, polygons, or lines -- the drawing pallet is there, but the markers don't show up on click.

In both cases when I try to save/export I get the following: "Cannot download layer: DrawingLayerView. Remove these layers to export the map."

Thanks!

pbugnion commented 6 years ago

Hi,

Thanks very much for the feedback.

Exporting maps with a drawing layer to PNG should just work -- I've opened a separate issue (#224). Note that the user won't be able to interact with the PNG, so presumably that won't solve your issue?

With the package as it currently stands, exporting an interactive version of the drawing layer to HTML is not possible -- user interactions in the drawing layer rely on the maps being backed by a Jupyter server. I agree that it would be nice to move that into the browser client so it still works when exported to HTML.

If I were in your position, I would either:

acresnick commented 6 years ago

Thanks much for the thorough feedback!

pbugnion commented 6 years ago

Closing this in favour of issues #224 and #226. Feel free to carry on discussing this here, or in the new issues, or re-opening if you think issues 224 and 226 don't address everything.