search

pbutti / GeneralBrokenLines

This is the port from svn to git of the gbl software. See https://www.terascale.de/wiki/generalbrokenlines/
0 stars 0 forks source link

install prefix rewrite #1

Closed tomeichlersmith closed 1 year ago

tomeichlersmith commented 2 years ago

The changing of the install prefix if it happens to coincide with the default value is poor form.

https://github.com/pbutti/GeneralBrokenLines/blob/23c281606a9860913f351afbda7f1f8fcecebfcf/cpp/cmake/ilcsoft_default_install_prefix.cmake#L3

and it led to a lot of time wasted when I was trying to install it to /usr/local on purpose.

Instead, this check could be changed to CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT which also requires updating the minimum cmake to 3.7.1.

tomeichlersmith commented 1 year ago

I've updated the upstream GBL repo https://gitlab.desy.de/claus.kleinwort/general-broken-lines/-/merge_requests/1 so there is no need to change this one.