search

pbylicki / rfhub2

Rewrite of rfhub with FastAPI
Apache License 2.0
30 stars 10 forks source link

[TestCases] Added Get Suites #449

Open MaciejWiczk opened 3 years ago

MaciejWiczk commented 3 years ago

@pbylicki I'm trying to figure out how to add suites with testcases, but I would need your help on that. I did some WIP code in this PR, but I'm missing logic on hierarchies etc. Could You navigate me?

pbylicki commented 3 years ago

@pbylicki I'm trying to figure out how to add suites with testcases, but I would need your help on that. I did some WIP code in this PR, but I'm missing logic on hierarchies etc. Could You navigate me?

@MaciejWiczk The main idea there, was that we only add/delete suites as suite hierarchies, not individual suites. That means that endpoint should expect a full suite hierarchy, which is a tree of nested suites, with the tree root being top-level suite, not a part of other suite. It simplifies creation of individual suites and relations between them so that we have easy read access to them and can treat them as regular resource then. Once the suites are saved and you have the IDs returned, adding test cases is straightforward because each test case is linked with specific suite. So these endpoints should just wrap existing repository methods, with no special logic involved, it's already handled there. There will be more work on CLI side to build the hierarchies from provided suites

codecov[bot] commented 2 years ago

Codecov Report

Merging #449 (604474d) into master (1b5b6c8) will decrease coverage by 0.61%. The diff coverage is 70.58%.

:exclamation: Current head 604474d differs from pull request most recent head e6ebd61. Consider uploading reports for the commit e6ebd61 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   96.24%   95.63%   -0.62%     
==========================================
  Files          46       47       +1     
  Lines        1385     1419      +34     
==========================================
+ Hits         1333     1357      +24     
- Misses         52       62      +10
Impacted Files Coverage Δ
rfhub2/api/utils/db.py 95.00% <66.66%> (-5.00%) :arrow_down:
rfhub2/api/endpoints/suites.py 70.00% <70.00%> (ø)
rfhub2/api/router.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b5b6c8...e6ebd61. Read the comment docs.