search

pbyrne84 / DynamicReturnTypePlugin

135 stars 7 forks source link

Allow ::class constant be used as parameter. #49

Closed Strate closed 9 years ago

Strate commented 9 years ago

Seems that ::class constant is not working for completion.

pbyrne84 commented 9 years ago

Could you give me the phpstorm/php plugin build version? The internal api can change slightly in releases and 9.5 EAP is doing the rounds so I have to watch out for stuff.

Thanks

On 2 September 2015 at 15:26, Artur Eshenbrener notifications@github.com wrote:

Seems that ::class constant is not working for completion.

— Reply to this email directly or view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/49.

Strate commented 9 years ago

I am using 141.2462 (9.0.2) now.

pbyrne84 commented 9 years ago

Can I have a bit more of an example as this seems to be an uncovered edge case/change.

Thanks

Strate commented 9 years ago

I created repository: https://github.com/Strate/dynamicReturnTypePluginTest/tree/master

pbyrne84 commented 9 years ago

Aaah, okay it is the array access bit.

Cheers

On 7 September 2015 at 09:24, Artur Eshenbrener notifications@github.com wrote:

I created repository: https://github.com/Strate/dynamicReturnTypePluginTest/tree/master

— Reply to this email directly or view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/49#issuecomment-138230485 .

pbyrne84 commented 9 years ago

I started doing it but it turned into a rabbit hole so I released 50 on its own. I will get back to your 49 tomorrow

pbyrne84 commented 9 years ago

2.0.5 which I just uploaded should fix this issue.

On 7 September 2015 at 18:11, Patrick Byrne pbyrne84@googlemail.com wrote:

Aaah, okay it is the array access bit.

Cheers

On 7 September 2015 at 09:24, Artur Eshenbrener notifications@github.com wrote:

I created repository: https://github.com/Strate/dynamicReturnTypePluginTest/tree/master

— Reply to this email directly or view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/49#issuecomment-138230485 .

Strate commented 9 years ago

Seems it fixed! Thank you!