pbyrne84 / DynamicReturnTypePlugin

135 stars 7 forks source link

Plugin stopped working with the current PhpStorm 2017.1 EAP #65

Open bashofmann opened 7 years ago

bashofmann commented 7 years ago

The plugin stopped working, return types for configured method or function calls are not resolved anymore.

Version details are:

PhpStorm 2017.1 EAP Build #PS-171.3019.12, built on February 8, 2017 PhpStorm EAP User Expiration date: March 10, 2017 JRE: 1.8.0_112-release-b702 x86_64 JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o Mac OS X 10.12.3

Please let me know if I can provide further information.

jkuchar commented 7 years ago

I have made a little bit of testing: (Win10x64)

pbyrne84 commented 7 years ago

Okay totally not work or ::class not working?

https://github.com/pbyrne84/DynamicReturnTypePluginTestEnvironment/blob/e783baa48ecba8ee4268ae207728fe8a1c119401/TestEnvironment/lib/DynamicReturnTypePluginTestEnvironment/FieldCallTest.php#L71-L134

The first test in here is failing and the last test is for me. This can be likely fixed and I will look at it now.

There are so many edge cases failing at the mo due to internal changes (I believe to allow greater flexibility to allow support for stuff that cannot conform to statically typed principles ) that full support of all the features again may need a major redesign of certain bits such as interchanging with the symfony plugin stuff.

I expected things to be failing a lot worse by now as anything can break in any eap until the new internal api is finalized.

On 20 February 2017 at 18:59, Jan KuchaΕ™ notifications@github.com wrote:

I have made a little bit of testing: (Win10x64)

  • PS-171.3224.10 does not work
  • PS-171.3019.12 does not work
  • PS-171.2822.14 does work

β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/65#issuecomment-281158016, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9IYzoQGCHlFVWXp-qNR_TM8wpfvU8Tks5reeKagaJpZM4L_E17 .

beardcoder commented 7 years ago

Only ::class is not working

pbyrne84 commented 7 years ago

The binary here https://github.com/pbyrne84/DynamicReturnTypePlugin/blob/6ce74cc409c10105ece74907d2ec0aecd5af1d40/deploy/DynamicReturnTypePlugin.zip should fix ::class

I changed the from build to 171.3566

which is latest eap.

I will do a proper release tonight if it solves this problem for you.

More complicated stuff as passing something from a configured container through another configured container is still broken though

https://github.com/pbyrne84/DynamicReturnTypePluginTestEnvironment/blob/b89f801d4cce2a0553b981dd4ca6d904b4794c75/TestEnvironment/lib/DynamicReturnTypePluginTestEnvironment/LocalMethodCallTest.php#L62-L75

 $this
            ->localGetFullMock($testEntity)
            ->getA();
bashofmann commented 7 years ago

::class works for me again. Thanks πŸ‘

pbyrne84 commented 7 years ago

Cheers :)

On 28 February 2017 at 11:31, Bastian Hofmann notifications@github.com wrote:

::class works for me again. Thanks πŸ‘

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/65#issuecomment-283015615, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9IY9GuAVmkoZOdNy0o9CiJc_Rz7lMgks5rhAWDgaJpZM4L_E17 .

beardcoder commented 7 years ago

Perfect It works :) big Thank you

pbyrne84 commented 7 years ago

I had a look at this morning in intellij and ::class was working but there can be many permutations of both working and non working.

Can I have a sample to verifiy?

Thanks

On 11 May 2017 at 20:04, Marcos Passos notifications@github.com wrote:

Return type with ::class is not working anymore:

PhpStorm 2017.1.3 Build #PS-171.4424.11, built on April 26, 2017 JRE: 1.8.0_112-release-736-b21 x86_64 JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o Mac OS X 10.12.4

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/65#issuecomment-300886830, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9IY6Ep9_s3cnP1jjKslV7KkQNOmTzrks5r41vNgaJpZM4L_E17 .

Daniel-Gr commented 6 years ago

I experienced the same issue with PhpStorm 2017.3 Build PS-173.3942.32. Windows 10 (x64), Java 1.8.0_152. (The configured function calls are not resolved anymore.)

Any ideas?

Thanks!

bjdelange commented 4 years ago

I've just upgraded from PhpStorm 2019.1 to 2019.3 and the plugin doesn't work anymore :( It worked fine before, I'm very happy with it !

jkuchar commented 4 years ago

You do not need it anymore, as PHPStorm supports this out-of-the box. πŸ˜‰ example defintion

bjdelange commented 4 years ago

Cool ! I see a ton of these files in PhpStorm's own files. Never knew about it.

Can't get it to work in my project though :( I replaced my dynamicReturnTypeMeta.json

{
    "methodCalls": [
        {
            "class": "\\Symfony\\Component\\DependencyInjection\\ContainerInterface",
            "method": "get",
            "position": 0
        }
}

with .phpstorm.meta.php in the root of the project

<?php

namespace PHPSTORM_META {
    override(\Symfony\Component\DependencyInjection\ContainerInterface::get(0), map(['' => '@']));
}

disabled the plugin, invalidated caches and restarted.

I don't have the symfony plugin activated as this isn't a symfony project, I only use the container.

bjdelange commented 4 years ago

After upgrading to PhpStorm 2019.3.1 the plugin works again !

BobMali commented 4 years ago

Aaaaand stopped working again with Phpstorm 2020.1. At least for me.