search

pbyrne84 / DynamicReturnTypePlugin

135 stars 7 forks source link

Please migrate to PhpTypePriovider3 #70

Open neuro159 opened 7 years ago

neuro159 commented 7 years ago

PhpTypePriovider2 is deprecated since 2016.3 and will be removed in 2017.3

Migration is pretty straightforward, but I can provide assistance if required.

dmvdbrugge commented 6 years ago

Any word on this? I'd really love to have this plugin working again without downgrading PhpStorm.

pbyrne84 commented 6 years ago

Sorry truthfully I have been very busy and I moved away from PHP to Scala a few years ago mostly due to I am quite opposed to the rampant magic method stuff that was prevalent under a lot of the testing frameworks leading to it being painful to support from a static analysis perspective (required by any tooling for it to be easy).

I appreciated what a lot of the PHP core team did (I still peruse internals) but from a test framework perspective things were going down paths that would lead to very hard tool support and those choices would follow wherever I moved to. Scala has magic but the magic has to mostly be machine provable versus defaultly brain provable only with php.

I really need to create the simplest new plugin project every for me to reverse engineer.

Also in

https://confluence.jetbrains.com/display/PhpStorm/PHP+Open+API

The interface is PhpType getType(PsiElement element);

Implementation is public String getType(PsiElement e)

Which I am not convinced is intentional but I am tired.

I so hate confluence, everytime I double click it bounces around instead of select word. A very bad implementation of principle of least astonishment :(

I find using github repos and

http://vladsch.com/product/markdown-navigator

far more developer friendly :)

Out of interest do you use

  1. Masks
  2. Script engine calls
  3. The magic interop between this and the symfony plugin (https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/35) which felt like a minor miracle fixing first time around.

I will see what I can do anyway.

On 25 April 2018 at 22:19, Dave van der Brugge notifications@github.com wrote:

Any word on this? I'd really love to have this plugin working again without downgrading PhpStorm.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/70#issuecomment-384437787, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9IYzzwR1eSPFJSZil1UL6fUALu48OEks5tsOhpgaJpZM4O_7Di .

dmvdbrugge commented 6 years ago

Thanks for your time. I unfortunately have no other choice than PHP (or, well, JavaScript, but that's no choice :p ). I can't speak as to the contents, but I share your dislike of Confluence.

As to your question: so far I have only ever needed to use masks, but then again, I haven't used this in a Symfony project yet.

pbyrne84 commented 6 years ago

Well the majority still works as Alexey never purged PhpTypeProvider2. Symfony stuff seems to be borked or I can't remember how it is configured and a remapped thing passing into a remapped thing expecting the original remapped thing to be return is broken and has been for a while.

I have a release ready anyway for PhpTypeProvider3

Basic array access stuff will be working again.

dmvdbrugge commented 6 years ago

Thanks man, you're the best!