search

pc-coholic / dw-plugin-recaptcha2

reCaptcha plugin for Dokuwiki
https://www.dokuwiki.org/plugin:recaptcha2
2 stars 4 forks source link

Not working with PHP v7.x.x PHP errors #3

Closed raykai closed 7 years ago

raykai commented 7 years ago

Hi, I'm getting some PHP errors when running under PHP v7.x.x im running PHP v 7.1.7 on my server.

Warning: Declaration of action_plugin_recaptcha2::register(&$controller) should be compatible with DokuWiki_Action_Plugin::register(Doku_Event_Handler $controller) in /dokuwiki/lib/plugins/recaptcha2/action.php on line 13

cant get the plugin to work.

pc-coholic commented 7 years ago

Could you please let me know, which version of DokuWiki you are running?

To be fair, I haven't used this plugin on PHP7.x yet... So I'll have to investigate this issue myself first.

raykai commented 7 years ago

I'm running the latest stable version of DokuWiki: Release 2017-02-19b "Frusterick Manners"

pc-coholic commented 7 years ago

I am currently not able to test anything - but perhaps you can :-)

Could you please check if changing in action.php from function register(&$controller)

into

function register(Doku_Event_Handler $controller)

I saw this change upstream and it could probably fix your problem, too...

raykai commented 7 years ago

il try it il let you know tonight

raykai commented 7 years ago

ya that seems to fix it .

Tho there is an other prob. il open an other post

pc-coholic commented 7 years ago

Thank you very much for your feedback. :-)