"background.service_worker is currently disabled"

[NewsGuyTor]

I'm struggling to get this working:

Perhaps this is relevant: https://stackoverflow.com/questions/75043889/manifest-v3-background-scripts-service-worker-on-firefox

I hope you can create xpi builds, that way people won't have to install a temporary extension.

[pc035860]

I see, Firefox is a different build.

[NewsGuyTor]

I managed to fix it, the background should be:

   "background": {
      "service_worker": "background.js",
      "scripts": ["background.js"]
   },

[pc035860]

@NewsGuyTor I've added the xpi build to the release 👍.

[NewsGuyTor]

Awesome! Any plans to upload them to the Firefox/Chrome stores?

[pc035860]

Awesome! Any plans to upload them to the Firefox/Chrome stores?

I'm not the author of the original extension. I think I'll just leave it as it is for now and see what happens.

[NewsGuyTor]

Awesome! Any plans to upload them to the Firefox/Chrome stores?

I'm not the author of the original extension. I think I'll just leave it as it is for now and see what happens.

Why? The original was under MIT, so you are allowed to do whatever, including distributing it:

https://github.com/sonigy/YCS/blob/master/LICENSE

You should btw add the MIT license to this fork, that's the only thing required by the MIT license. Added PRs

[pc035860]

Why? The original was under MIT, so you are allowed to do whatever, including distributing it:

https://github.com/sonigy/YCS/blob/master/LICENSE

You should btw add the MIT license to this fork, that's the only thing required by the MIT license. Added PRs

I mean, not a single line of code from this repository is in the original repository. Does the license still apply?

[NewsGuyTor]

Why? The original was under MIT, so you are allowed to do whatever, including distributing it: https://github.com/sonigy/YCS/blob/master/LICENSE You should btw add the MIT license to this fork, that's the only thing required by the MIT license. Added PRs

I mean, not a single line of code from this repository is in the original repository. Does the license still apply?

Yes, he added the MIT license manually to the Readme for the extension too, so he clearly intended it to apply for the project.

The Firefox version was uploaded as Mozilla Public License 2.0, that also gives us permission to fork, change and redistribute the fork (provided we share source code ofc): https://addons.mozilla.org/en-US/firefox/addon/ycs/

Which license we use is kinda academic since both apply without any issues, but I guess MPL 2.0 could be used since it definitely applies to the source code this fork originates from.