search

pc035860 / YCS-cont

Chrome Extension: YCS. Search for comments and authors in YouTube videos
MIT License
80 stars 6 forks source link

clicking on timestamp doesn't focus on video #11

Open hcgiub001 opened 5 months ago

hcgiub001 commented 5 months ago

Can we have it when we click on timestamp that the video gets focus. This behaviour is normal with using general comments in YouTube but not in YCS. thanks for consideration

NewsGuyTor commented 5 months ago

I don't want this, at all! If this is implemented, it should be an optional opt-in setting, not something default.

This would totally destroy the extension user experience while watching videos in PiP.

hcgiub001 commented 5 months ago

I don't want this, at all! If this is implemented, it should be an optional opt-in setting, not something default.

This would totally destroy the extension user experience while watching videos in PiP.

I didn't realise this could cause an issue with pip. have you tested with normal timeline links to see if it affects it? if it does then allowing it as an option would be cool

hcgiub001 commented 5 months ago

I'm not a coder but if it can detect it's in pip then you can alter the behaviour so it takes focus if not in pip and doesn't take focus if in pip

NewsGuyTor commented 5 months ago

Yeah, it's an issue with normal comments, it scrolls to the top, massively annoying! I converted this extension to an userscript that fixes it here: https://gist.github.com/NewsGuyTor/ff655400ff400d192de7e83759386971

BTW, I recommend that you install an embedded PIP extension (like Enhancer) instead, I don't get why you'd ever prefer to lose context of where you are in a comment thread. It's a much more pleasant experience (vid has no sound):

https://github.com/pc035860/YCS-cont/assets/19603024/fec39f6e-4cbc-452d-8b13-f0db9eae22b8

drhouse commented 5 months ago

I can highly recommend this chrome addon that shows timestamped comments at the appropriate time on the upper-corner of the YouTube video: Timestamped YouTube Comments

unnamed

Features:

hcgiub001 commented 5 months ago

Yeah, it's an issue with normal comments, it scrolls to the top, massively annoying! I converted this extension to an userscript that fixes it here: https://gist.github.com/NewsGuyTor/ff655400ff400d192de7e83759386971

BTW, I recommend that you install an embedded PIP extension (like Enhancer) instead, I don't get why you'd ever prefer to lose context of where you are in a comment thread. It's a much more pleasant experience (vid has no sound):

ScreenFlow.mp4

I tested myself and can see how annoying this is. But can you also see how annoying it could be for those that don't use pip? I've used enhancer before for that pip functionality. I found I liked video being paused when viewing comments.

but I found a nice extension that "Comments - Scroll to comment (after clicking on a timestamp or changing fullscreen mode)" it's called Tweaks, it's a bloody amazing extension. you can set a shortcut for that action. so I click on a timestamp. video takes focus. then I can click the shortcut so it goes exactly back to where I clicked the timeline.

If you don't use pip, can you see I have to scroll up to watch the video and I lose focus on the comment anyway

hcgiub001 commented 5 months ago

I can highly recommend this chrome addon that shows timestamped comments at the appropriate time on the upper-corner of the YouTube video: Timestamped YouTube Comments unnamed

Features:

  • Pause to persist a comment
  • Hover over a comment to see its replies
  • Click the Comments icon in the video bar to toggle comments on/off
  • Click on a comment to open a new tab with that comment at the top of the comment section (useful for replying to comments)

that's actually cool thanks

hcgiub001 commented 5 months ago

@NewsGuyTor if you want more information on tweaks. let me know.