search

pc035860 / angular-easyfb

Super easy AngularJS + Facebook JavaScript SDK.
MIT License
440 stars 69 forks source link

Add new Facebook page plugin #45

Closed lammertw closed 9 years ago

lammertw commented 9 years ago

This adds support for the new page plugin: https://developers.facebook.com/docs/plugins/page-plugin/

The like-box is now deprecated by Facebook (in favor of the new page plugin).

pc035860 commented 9 years ago

Hi @lammertw ,

Thanks for the PR! I'll merge it when the commented line is ready.

chanduk040 commented 9 years ago

Hi Team,

Thanks for giving support for page plugin. As mentioned I have added the above page plugin settings in angular-easyfb.js and I can able to use the page plugin.

But the Issue is if we try to give data-width="500" it is not getting affected like "post" plugin. It is applying only 180px width. I have also attached screenshot for your reference.

Below is the HTML I have written:

Could you please help/guide me to fix the width issue?

pageplugin_widthissue

chanduk040 commented 9 years ago

Hi Team,

Thanks for the reply..Updated the Plugin settings to 'href', 'width', 'height', 'hideCover', 'showFacepile', 'showPosts'..But this even didn't resolve the issue..Could you please check once and provide an example?

pc035860 commented 9 years ago

Hi @chanduk040 ,

I'm aware of the issue and trying to address it right now. Just wait for my good news!

chanduk040 commented 9 years ago

Oh Thanks a lot.. Would be waiting for your update..

pc035860 commented 9 years ago

Page plugin should work fine now in v1.3.0. Check out the updated example here: http://plnkr.co/edit/1c5cWB?p=preview

chanduk040 commented 9 years ago

Awesome!!! Its working perfectly.. Really thanks a lot for the quick fix..

chanduk040 commented 9 years ago

Hi @pc035860 ,

Unfortunately noticed one issue.. Page plugin width issue is working fine on routing.. But for the initial load, the width issue still occurs..

Providing the plunker url for your reference. I have checked the plunker to load page plugin by default so that you can see the issue..

http://plnkr.co/edit/RuUYWsfeYU67z1j8N8Ay?p=preview

pc035860 commented 9 years ago

Hey @chanduk040, try https://github.com/pc035860/angular-easyfb/commit/61570d8ede98cca90f6fc351e0f4ca0ad08b521c, spent lots of time and effort on this one.

chanduk040 commented 9 years ago

Hi @pc035860,

Really appreciate your effort & time.. Since you were responding very quickly and providing support for the plugin.. Really thanks for your help..