search

pc035860 / angular-highlightjs

AngularJS directive for syntax highlighting with highlight.js
http://pc035860.github.io/angular-highlightjs/example/
MIT License
294 stars 53 forks source link

Updated readme #46

Open bes89 opened 9 years ago

bes89 commented 9 years ago

added bower install highlightjs and used ---save parameter when installing packages

pc035860 commented 9 years ago

There's no --save nor --save-dev presented at https://github.com/angular-ui/ui-router/blob/master/README.md#get-started. I believe they meant to let the user to decide whether to add it or not?

bes89 commented 9 years ago

Whats wrong with --save? it just adds the new dependency to your package.json/bower.json. Sure, you can add it manually....

ethanhann commented 9 years ago

Installing highlightjs separately wouldn't be necessary if it is listed in angular-highlightjs's bower.json file as a dependency.

pc035860 commented 9 years ago

@ethanhann Actually, the highlight.js dependency was removed from bower.json due to #28 .

ethanhann commented 9 years ago

Ah, I understand the situation. Dependencies can be overridden in bower.json anyway, which is handy for allowing tools like wiredep to work, so it isn't a big deal.