search

pc035860 / angular-highlightjs

AngularJS directive for syntax highlighting with highlight.js
http://pc035860.github.io/angular-highlightjs/example/
MIT License
294 stars 53 forks source link

Add highlightjs to dependencies #54

Closed asnowwolf closed 8 years ago

asnowwolf commented 8 years ago

This package is dependent on highlightjs but not in bower.json's "dependencies" field.

pc035860 commented 8 years ago

Hi @asnowwolf ,

Though the highlightjs dependency is actually removed in #28 , it seems so many people asking about this. So I guess I'll just add it back this weekend. Thanks for the opinion.

pc035860 commented 8 years ago

Well, I changed my mind after checking out on the bower package's github repo.

It has one huge packed highlight.js with all languages included, and usually you'll only use one or two of them. This adds so much overhead to the network transfer and javascript parsing.

Size difference:

So I recommend that you just stay with the suggested way to include highlight.js described in README.

There's currently no official bower package of highlight.js (see here). You should either build highlight.js yourself or use the pre-built one on cdnjs.

Closing the issue.