pc2 / Aurora-HLS

Ready-to-link, packaged Aurora IP on four QSFP28 lanes, providing 100Gb/s throughput
Apache License 2.0
7 stars 3 forks source link

Add helper functions to support two cores per MPI rank #11

Closed papeg closed 4 months ago

papeg commented 6 months ago

Right now, the Aurora class is handling one aurora core. The check_status_core_global() function is assuming that there is one rank per aurora core. But in typical use cases, there is one rank per FPGA, which in this case means two aurora cores. This should be possible to handle in some way, maybe by adapting the Aurora Class or creating another Class which handles two aurora cores.

Mellich commented 4 months ago

So what about this issue? Should we declare it as wont-fix? I think the workaround mentioned in #14 is sufficient or are there any objections?

papeg commented 4 months ago

Yes, as the ranks are not anymore in the scope of the helper class, this issue can be closed