pc2ccs / pc2v9

Version 9 of the PC^2 Programming Contest Control System
Eclipse Public License 2.0
47 stars 23 forks source link

Add Clarifications tab to Shadow Frame #763

Open lane55 opened 1 year ago

lane55 commented 1 year ago

Is your feature request related to a problem?

It is helpful to be able to easily view clars while monitoring shadowing.

Feature Description:

Add the Clarifications tab to the Shadow (Feeder) Frame.

Have you considered other ways to accomplish the same thing?

n/a

Do you have any specific suggestions for how your feature would be **implemented in PC^2?**

Do per description.

Additional context:

lane55 commented 1 year ago

It is possible but unlikely that the Feeder is never sent clarifiation updates. Very easy to test though.

lane55 commented 1 year ago

When adding Clarifications Pane to feeder, the Answer button was present. Remove ANSWER_CLARIFICATION Permission from default permissions for FEEDER account type.

lane55 commented 1 year ago

Add Next Contest label Provides a way to review clars as Shadow

clevengr commented 1 year ago

I don't understand the statement "Provides a way to review clars as Shadow". Clarifications are submitted to the Primary CCS only. The only way a PC2 Shadow would ever see a clarification is if the clar appeared, in complete form, in the Event Feed, AND we had a way to pull clars from such an Event Feed and "submit" them to the PC2 (Shadow) server. Merely adding a Clars tab to the Shadow Feeder frame isn't going to accomplish that. I see no point in just "adding a Clarifications tab to the Shadow Frame"; it appears to me that there is much more work involved in making it so that a Shadow has the ability to see Clars.

johnbrvc commented 1 year ago

I don't understand the statement "Provides a way to review clars as Shadow". Clarifications are submitted to the Primary CCS only. The only way a PC2 Shadow would ever see a clarification is if the clar appeared, in complete form, in the Event Feed, AND we had a way to pull clars from such an Event Feed and "submit" them to the PC2 (Shadow) server. Merely adding a Clars tab to the Shadow Feeder frame isn't going to accomplish that. I see no point in just "adding a Clarifications tab to the Shadow Frame"; it appears to me that there is much more work involved in making it so that a Shadow has the ability to see Clars.

Issue #776

clevengr commented 1 year ago

I don't understand the statement "Provides a way to review clars as Shadow". Clarifications are submitted to the Primary CCS only. The only way a PC2 Shadow would ever see a clarification is if the clar appeared, in complete form, in the Event Feed, AND we had a way to pull clars from such an Event Feed and "submit" them to the PC2 (Shadow) server. Merely adding a Clars tab to the Shadow Feeder frame isn't going to accomplish that. I see no point in just "adding a Clarifications tab to the Shadow Frame"; it appears to me that there is much more work involved in making it so that a Shadow has the ability to see Clars.

Issue #776

Ok, I see that there is a separate issue (#776) for this. That means that this issue (#763) should be marked in some way as "dependent on #776". In Bugzilla there was a way to actually mark Issues as having dependencies. I don't know if GitHub supports such a thing.