pcal43 / fastback

Fast, incremental Minecraft world backups. Powered by Git.
https://pcal43.github.io/fastback/
GNU General Public License v2.0
133 stars 20 forks source link

Redundant dependency #294

Closed RareScrap closed 1 year ago

RareScrap commented 1 year ago

Feature description

Remove xyz.nucleoid:packet-tweaker dependency from the fabric build script.

Problem to solve

It seems that this package isn't using from fastback code base directly. It's rather used by server_translations_api that already includes it. So it's pointless to depend no this package directly

Server startup log:

[21:13:56] [main/INFO]: Loading 50 mods:
        - fabric-api 0.90.0+1.20.2
           |-- ...
        - fabricloader 0.14.22
        - fastback 0.16.2+1.20.2-fabric
           |-- com_googlecode_javaewah_javaewah 1.2.3
           |-- fabric-permissions-api-v0 0.2-SNAPSHOT
           |-- net_i2p_crypto_eddsa 0.3.0
           |-- org_apache_sshd_sshd-common 2.10.0
           |-- org_apache_sshd_sshd-core 2.10.0
           |-- org_eclipse_jgit_org_eclipse_jgit 6.7.0.202309050840-r
           |-- org_eclipse_jgit_org_eclipse_jgit_ssh_apache 6.7.0.202309050840-r
           |-- packet_tweaker 0.5.0+1.20.2-rc1
           \-- server_translations_api 2.1.0+1.20.2-rc2
                \-- packet_tweaker 0.5.0+1.20.2-rc1 <--- THIS
        - java 17
        - minecraft 1.20.2

Ways to implement

1) Remove xyz.nucleoid:packet-tweaker dependency from fabric/build.gradle

Additional details / screenshots