search

pcal43 / quicksort

Minecraft mod. Low-effort item sorting to keep your workshop organized.
https://modrinth.com/mod/quicksort
MIT License
7 stars 3 forks source link

Fix for issue #31: Items sorting faulty when a hopper inserts an item during sorting #41

Closed finnosdiemitdemo closed 6 months ago

finnosdiemitdemo commented 8 months ago

Fix for #31 + removed the endless loop for every server tick

finnosdiemitdemo commented 8 months ago

So thanks for taking the time to dig into this. But it's a little hard for me to understand the change with all of the reformatting you did here. Would it be possible for you to reduce the change down to only the necessary diffs?

I removed the code formatting stuff.

pcal43 commented 8 months ago

So, I appreciate that. But you still seem to have done a bunch of other refactoring that is more about style than substance, and it's still not immediately obvious to me what the fix actually is. I don't have a lot of time for these projects, and I need to be able to review changes like this quickly.

If you want to have a conversation about style as well, we can do that, but I'd prefer it in a separate PR. But for this one, I really need to see a minimal diff.