search

pcarbo / varbvs

Large-scale Bayesian variable selection for R and MATLAB.
http://pcarbo.github.io/varbvs
GNU General Public License v3.0
42 stars 14 forks source link

subroutine missing #14

Closed xiangzhu closed 7 years ago

xiangzhu commented 7 years ago

Hi Peter,

I think one subroutine computevarlb.m used in varbvsmix.m is missing.

https://github.com/pcarbo/varbvs/blob/master/varbvs-MATLAB/varbvsmix.m#L357

Repo search result:

https://github.com/pcarbo/varbvs/search?utf8=%E2%9C%93&q=computevarlb&type=

pcarbo commented 7 years ago

@xiangzhu The function is defined on line 430 of varbvsmix.m. Is it not working for you?

xiangzhu commented 7 years ago

I see. Thanks!

I vaguely remember that the lower bound calculation was in a separate M file in previous versions, so I kept searching a file with name computevarlb.m.

I will close this issue now.

pcarbo commented 7 years ago

@xiangzhu Some terms in the variational lower bound are computed in separate functions, e.g., int_gamma.m and int_klbeta.m.

xiangzhu commented 7 years ago

Yes, I see these files, which seem to be very similar to previous spike-and-slab versions.