pcbway / PCBWay-Plug-in-for-Kicad

PCBWay Plug-in for Kicad
MIT License
33 stars 8 forks source link

Export doesn't support the “Exclude from BOM” and “Exclude from position files” options #9

Open rhard opened 1 year ago

rhard commented 1 year ago

Please support the above-mentioned options so the BOM will not be populated with unneeded components. You can check the JLC repository for a solution: https://github.com/bennymeg/JLC-Plugin-for-KiCad/blob/master/plugins/process.py

 if not footprint.GetAttributes() & pcbnew.FP_EXCLUDE_FROM_POS_FILES:
 if not footprint.GetAttributes() & pcbnew.FP_EXCLUDE_FROM_BOM:

image

pcbway commented 1 year ago

Hi,We have updatd the plugin for version 7,the problem could be solved

accsysorg commented 10 months ago

I had the same issue, and have fixed it. I can't push the code change, but you just need to add the following at line 111 in process.py:

if placed == True:

Then include the for and if statement underneath in the conditional block.

chibiconsulting commented 5 days ago

Still an issue in KiCad v8.0.4 with plugin v1.0.0.

pcbway commented 5 days ago

Could you tell me the detail issue?

chibiconsulting commented 5 days ago

Sure, see T-1P17W321128A. Simple circuit, LED, Resistor & Pin header. Pin header has "Exclude from bill of materials" checked. Issue9-DNP Pin header is included in BOM:

Designator Quantity Value Footprint Package
D1 1 LED LED_0603_1608Metric smt
J1 1 Conn_01x02 PinHeader_1x02_P2.54mm_Vertical tht
R1 1 100 R_0603_1608Metric_Pad0.98x0.95mm_HandSolder smt
pcbway commented 5 days ago

Hi I get it,thanks very much. I have asked the engineer evalute it. Now if you choose DNP,it will show in the bom. But if choose exclude from bill of materials,it will not show it.Thanks for the feedback.

pcbway commented 3 days ago

Before we fix the problem,you could choose DNP,so our sale will not make quotation for the component