pcca-matrix / PCCA-Layout

HyperSpin layout for Attract-Mode
GNU General Public License v3.0
7 stars 6 forks source link

Bezels should be ontop of themes #15

Closed ghost closed 4 years ago

ghost commented 4 years ago

Bezels should be ontop of themes.

pcca-matrix commented 4 years ago

We discussed it on discord, I cannot without removing the bezel from the background animation. removing the bezel from the animation does not look good, it stay static between the background transition.

ghost commented 4 years ago

I remember talking about it and you brought up rewriting that shader but I guess you tried and it doesn't look good. No problem.

ghost commented 4 years ago

I played around with your code on my PC (no commits of course). Here is how it looks with the bezels on top. After all, when we consider the need for bezels in the first place - it is intended only for users with wide screen displays who want to run the themes in their native 4:3 aspect ratio. A user with a 4:3 screen doesn't need bezels Second thing to take into account is that much of the artwork was created with the idea in mind the the artifacts will be off-screen in the first place and will not be seen.

With the bezels on top there are far less visual artifacts and the transitions look fine IMO - we can differ here as I am not a native HS user.

Here is the hacked code (simple and crude of course): layout.zip

Here is a video demo of it in action: https://youtu.be/CGHDgOE7yZQ

Tell me what you think my friend! :)

pcca-matrix commented 4 years ago

exactly , but it's not smooth when you have a mix of hyperspin theme, hd and video theme in full res.

what I'm going to do is an option to let the user choose between full transition or partial bezel transition.

partial transition, will be in fact as currently, but at the end of the background transition , a static bezel image will be put on top of the existing bezel incrusted in background.

in this way, this will mask the artwork that exceeds without disturbing too much the transitions when you switch between differents theme res.

I will do this later because it involves modifying the shader and i must modify it first for the probleme with small overlay.

Sent from my iPhone

ghost commented 4 years ago

I catch your drift. In the meanwhile I am playing around with your layout script, making the wheel pointer and current wheel logo fade as well. It looks good. I have a few ideas to add for the options menu but as you said first we get rid of the current issues which are more important.

ghost commented 4 years ago

I've updated to the latest version and the bezels are indeed on top. There are two small issues:

  1. When you first enter the theme from the main menu it doesn't load anything but the current wheel logo
  2. The bezels pop on-top of the theme which is very noticeable in some themes. You can see narrow bezels and then it loads a wider bezel that "covers" the edges of the theme hence the popping effect.

I'm sure you have a reason to do the bezels like you did but can't we just load them after the snap in the layout script or give it a higher zorder? I did it in my themes and it works..

ghost commented 4 years ago

Look at the character's right side of the body at the bottom left - when the game theme loads it is shown and then the bezels pops ontop of it.

https://youtu.be/uwZOS-5z9fk

Another example for this popping - look closely at the edge of the bezel on the right side when I transition between the game themes - there is this shadow on the edge of the bezel that comes in a delayed fashion:

https://youtu.be/WhEMfQxZz_8

pcca-matrix commented 4 years ago

yes it's because the bezels are added later ... maybe I'll add a 3rd bezel option, "fixed bezel" for those who do not mix 4/3 and hd themes.

ghost commented 4 years ago

Good idea. BTW - the bezels that load later also cut the corners of the themes - it's evident in the default mame theme.

Capture

ghost commented 4 years ago

Resolved!