pccasto / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

freedb issues #139

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. run rrip_cli with freedb turned on

Unable to get info from cd from freedb. Shows default values only. rr
release 0.44. Tried on linux and os x. 

Suddenly freedb doesn't seem to work. Any idea what the problem is? Is it
rr, freedb or me?

Thanks

Original issue reported on code.google.com by mikebannister on 8 Dec 2007 at 3:56

GoogleCodeExporter commented 8 years ago
I'm getting this with 0.42 gui as well, running under Ubuntu 7.10.

Original comment by VoteNinj...@gmail.com on 8 Dec 2007 at 9:16

GoogleCodeExporter commented 8 years ago
same here, gui and cli linux.

Original comment by max.nem...@gmail.com on 9 Dec 2007 at 9:28

GoogleCodeExporter commented 8 years ago
I'm experiencing the same problem with both 0.44 and a brand-new subversion 
checkout.

Original comment by frank...@bynumlaw.net on 10 Dec 2007 at 8:51

GoogleCodeExporter commented 8 years ago
The problem seems to be that Freedb's CDDBP interface (the port 8880 interface) 
that
Rubyripper uses is broken.  The quickest option (I think?) would be to switch to
using freedb's port 80 cddb.cgi interface.  This also has the advantage of 
letting
users switch to freedb2.org or freedb.musicbrainz.org, or other alternatives 
that
support only the port 80 interface.  

Original comment by ninethi...@gmail.com on 11 Dec 2007 at 2:29

GoogleCodeExporter commented 8 years ago
I've attached a patch that switches to the HTTP interface for FreeDB, which is
currently working.  This patch should apply against the current SVN version of
RubyRipper.  
As a side note, it also fixes a problem I had with Flacs not encoding.
To apply it in a Linux or Mac environment, copy the patch file into the 
directory
where your rr_lib.rb lives and open a terminal to that directory, and type 
"patch
rr_lib.rb patch.diff"

Original comment by ninethi...@gmail.com on 11 Dec 2007 at 8:48

Attachments:

GoogleCodeExporter commented 8 years ago
Oops -- that patch fails for discs that have multiple entries in FreeDB.  
Working on
that...

Original comment by ninethi...@gmail.com on 11 Dec 2007 at 8:51

GoogleCodeExporter commented 8 years ago
Fixed.  Most likely, the FreeDB CDDBP interface will come back up soon.  In the
meantime, this works for the current SVN version.

Original comment by ninethi...@gmail.com on 11 Dec 2007 at 9:43

Attachments:

GoogleCodeExporter commented 8 years ago
When I try your patch using the svn version, I immediately get an error that it 
could
not connect to the internet (and server).  What server are you using?  Since it
almost immediately does it for me, it would seem its an error connecting to the
internet (I'm on a really slow connection). Here is the commandline output:

preparing to contact freedb server
parsing url freedb.org
getting handshake
performing query
Exeption thrown: Address family not supported by protocol - socket(2)

Original comment by max.nem...@gmail.com on 11 Dec 2007 at 10:33

GoogleCodeExporter commented 8 years ago
Ah, sorry -- I neglected to say that it requires a change in FreeDB path as 
well. 
I'm using:  http://freedb.org:80/~cddb/cddb.cgi
At the moment, its responding VERY slowly, but it was working fine earlier 
today.
Other options can be found here:
http://groups.google.com/group/comp.sys.acorn.apps/browse_thread/thread/ff57a4af
47f822f7#anchor_f33cb16f4708b652
(among other places)

Original comment by ninethi...@gmail.com on 11 Dec 2007 at 10:45

GoogleCodeExporter commented 8 years ago
Awesome, works with the musicbrainz url.  Thanks.

Original comment by max.nem...@gmail.com on 11 Dec 2007 at 11:13

GoogleCodeExporter commented 8 years ago
Another update, this time compliant with FreeDB2.org (now known as 
TrackType.org),
which is a FreeDB alternative.
As before, I've included a patch (apply it to your source) and the whole 
rr_lib.rb
file (if you'd rather just replace your existing rr_lib.rb).   Please remember 
to
also change your FreeDB site from the current "freedb.org"  to a full HTTP url, 
like
"http://freedb2.org:80/~cddb/cddb.cgi"

Original comment by ninethi...@gmail.com on 11 Dec 2007 at 11:15

Attachments:

GoogleCodeExporter commented 8 years ago
Hello there. In case you have been wondering where I was, I was offline. 
Changing my
internet provider turned out to be a stupid idea. Nevertheless I am back again. 
And
to my big surprise I see patches :) Nothing can make me more happy :D This is 
the
true opensource spirit.

I'll look into it to merge this as soon as I have some time. Thanks for the 
patch again!

Original comment by rubyripp...@gmail.com on 12 Dec 2007 at 7:38

GoogleCodeExporter commented 8 years ago
The original (unpatched) versions of RR will work with gnudb.dnudb.org

It's not the best solution: it's simply a dump of freedb from about a year ago 
(so
not good for CDs from the last year). However, it is a simple fix for those that
don't want to checkout (and patch) the svn version.

Original comment by tin...@gmail.com on 13 Dec 2007 at 9:50

GoogleCodeExporter commented 8 years ago
I've replaced rr_lib.rb with the new download, reconfigured Rubyripper 0.4.4 and
reinstalled it. Using the GUI, with EITHER http://freedb.org:80/~cddb/cddb.cgi 
OR
with http://freedb2.org:80/~cddb/cddb.cgi, I still do not get any disk info. 
Linux
7.10, 32-bit.

Original comment by drlm...@gmail.com on 13 Dec 2007 at 1:43

GoogleCodeExporter commented 8 years ago
As the patch seems to work at first glance, I've imported it into svn with 
commit 
171. 

Can anyone test for regressions? First one seems to me that the Genre field is 
always Unknown.

Original comment by rubyripp...@gmail.com on 15 Dec 2007 at 3:12

GoogleCodeExporter commented 8 years ago
drlmfox -- sorry, i was swamped with work and Christmas shopping.  Do you see 
any
console output?  In "preferences->other", click on "debug mode" and "verbose 
mode". 
Then restart RubyRipper from a terminal window, if it isn't already, and see 
what it
spits out on the console.  Hopefully, there's an error message that gives us a 
clue. 

rubyripperdev -- you're most welcome.  I'm sorry that Ruby isn't my strong suit 
yet,
but its fun to try.  I haven't compared the actual data that comes back from 
the CGI
(port 80) method vs the CDDBP (port 8880) method; I was hoping they'd be 
identical,
but if genres aren't showing up then I guess not...  

Original comment by ninethi...@gmail.com on 17 Dec 2007 at 2:30

GoogleCodeExporter commented 8 years ago
It might be two things in my opinion:
1. The protocol isn't set correctly.
2. Musicbrainz does not share this information

Oh, do I wish I had more time to debug these. But the whole CGI thing is a bit 
new 
for me. I'll have to study it a bit, before I change anything.

Original comment by rubyripp...@gmail.com on 17 Dec 2007 at 5:31

GoogleCodeExporter commented 8 years ago
For the record, I am getting genres set using 
http://freedb2.org:80/~cddb/cddb.cgi .
 I tried Musicbrainz first, but they didn't recognize the first couple of CDs I
tried, so I went back to freedb2. 
So if genres aren't showing up from Musicbrainz, I'd probably print the response
they're sending to the console and see if they're setting genre at all.

Original comment by ninethi...@gmail.com on 17 Dec 2007 at 9:24

GoogleCodeExporter commented 8 years ago
With commit 172 all freedb issues should be gone. The default is now set to 
freedb2.org. This indeed shows no problems with the genre tag. Since I got too 
lazy 
to delete the freedb.yaml for every test I did, pressing refresh cd will 
refetch 
the info from the internet if the same disc info was already loaded.

If you encounter problems, make sure they are still there when deleting your 
settings file. Due to the change in freedb fetching (over http), a different 
kind 
of webserver adress is required. Default settings work for me.

I'll keep this open for another week. If nobody objects, I'll close it then.

Original comment by rubyripp...@gmail.com on 29 Dec 2007 at 2:29

GoogleCodeExporter commented 8 years ago

Original comment by rubyripp...@gmail.com on 3 Jan 2008 at 5:39