Hyphen character (-) in tags and filenames

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Rip a cd with a hyphen in the title of the album or one of the tracks
2. Check the tags

What is the expected output? What do you see instead?
Hyphen characters are removed both from the filename and from the tags. The
removal from the filenames could be a design descision, but from the tags
is a fault, as there is no reason to remove them.

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?

Using 0.4.4 on Kubuntu 7.10 with rrip_cli

Please provide any additional information below.

Sorry, I haven't installed the 0.5 release yet, and cannot find a changelog
anywhere...

Original issue reported on code.google.com by mar...@wustenberg.dk on 30 Jan 2008 at 9:57

[GoogleCodeExporter]

I just tested it in 0.5, same problem.

And I found the changelog by the way, in the README (?). Normally, these are in 
a
file called CHANGELOG. :)

Original comment by mar...@wustenberg.dk on 31 Jan 2008 at 4:52

[GoogleCodeExporter]

I discovered it's not only hyphens, but also a slash ( / ), and I suppose 
several
other characters. Stripping them from the filename is fine, for obvious reasons
(well, some of them), but they really shouldn't be taken away from the tags.

Original comment by mar...@wustenberg.dk on 31 Jan 2008 at 7:32

[GoogleCodeExporter]

Actually I didn't expect anyone to mind this. Why would you need such tokens to 
be 
displayed?

Implementation of your request is non-trivial, so please convince me.

Original comment by rubyripp...@gmail.com on 31 Jan 2008 at 9:51

[GoogleCodeExporter]

Consider ripping the album "Gorillaz" by the band of the same name. The first to
tracks are:

1) Re-Hash
2) 5/4 Five Four

This happened to me today. And the hyphen character really is in titles a lot!

Ideally, every character that exists should be possible to write into tags. 
flac uses
UTF-8 to store tag information, so it shouldn't be impossible, although I don't 
know
how rubyripper would handle this. Maybe filenames would be restricted more, but
modern filesystems (at least in the unix world) should be able to handle UTF-8
filenames correctly, too.

It's just a hassle that I have to go into Easytag afterwards and correct every 
title
with a special character in it.

If you do not want to implement this, I would consider adding a warning if such
characters are used, that these will be stripped and replaced with a 
whitespace. It
took some time before I noticed the behaviour, and it resulted in me having to 
go
through my previously ripped cd's again, just to make sure.

Original comment by mar...@wustenberg.dk on 31 Jan 2008 at 10:04

[GoogleCodeExporter]

hey, hey, don't get angry with me ;) Just curious why something is necessary. 
Nobody wants to implement something in his free time without seeing the extra 
value 
of it, right?

Original comment by rubyripp...@gmail.com on 31 Jan 2008 at 10:10

• Changed state: Accepted

[GoogleCodeExporter]

Of course I'm not angry! :D I really appreciate what you do! And I hope I am 
able to
help you improve this nice program.

Original comment by mar...@wustenberg.dk on 31 Jan 2008 at 10:12

[GoogleCodeExporter]

And by the way, I would love to help out programming this if I could, but I am 
in my
first year of computer science still, and the only scripting language I really 
know
is PHP.

Actually, I have wondered why you have not made a generic library of this, in, 
for
example, C. Wouldn't that make it easier to integrate these nice features in the
rippers already available out there?

I know that would be a huge workload, I'm just curious. :)

Original comment by mar...@wustenberg.dk on 31 Jan 2008 at 10:16

[GoogleCodeExporter]

hi--i'm new to linux, and friends convinced me rubyripper was best for flac 
rips, so
i switched from ubuntu's soundjuicer to rubyripper. but this issue--hyphens and 
all
'special characters' makes it impossible to copy some albums from one disc to 
another
in ubuntu. Soundjuicer used to have an option, "strip special characters" and 
this
used to make it possible to copy the albums. the special characters in the 
filenames
became underscores, but reappeared in tags and in amarok. 

anyway, hope you can make something like soundjuicer's 'strip special 
characters.'
Thanks, joshua

Original comment by joshua.r...@gmail.com on 18 Jul 2008 at 11:50

Attachments:

[GoogleCodeExporter]

Hi Joshua,
if Ubuntu is able to save it to disk, then it should be able to copy it to other
disks as well -- but maybe the destination disk has another filesystem?

Anyway, I just wanted to say that I found a workflow that works for me. In
rubyripper, enter artist, album, genre, and year information, leave the rest as 
is,
and then use Musicbrainz Picard to tag the rest. Works excellent for me. :)

Original comment by mar...@wustenberg.dk on 19 Jul 2008 at 9:07

[GoogleCodeExporter]

Hi there :)

On my setup (Ubuntu Hardy, Rubyripper 0.5.2), these characters get stripped by
Rubyripper but ARE passed to LAME. This works fine for hyphens, but slashes 
cause
LAME to trip up and fail the encode (the / creates obvious path issues!).

Thanks for all your hard work!

Original comment by dwalker...@gmail.com on 2 Aug 2008 at 4:08

[GoogleCodeExporter]

I think svn r299 solves much of your problems. If anything remains, please open 
up a
new issue. Note that double quotes are removed from the filename because I get 
all
kind of errors if I leave it. They are preserved for the tags however.

Original comment by rubyripp...@gmail.com on 7 Aug 2008 at 4:40

• Changed state: Fixed