pccasto / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

rr crashes when cd in drive, cddb checked and no internet connection #204

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Version I tried is r. 241

For reproducing:
1. RR -> Settings -> freedb=true
2. Disconnect from internet
3. insert a CD that is unknown to RR (no local info about it)
4. start RR

From the console I get:
preparing to contact freedb server
Created query string:
/~cddb/cddb.cgi?cmd=cddb+query+d60eca0f+15+150+2431+19809+38053+63601+81083+1007
59+115407+147145+168412+191853+213471+216091+237680+252425+3788&hello=anonymous+
my_secret.com+rubyripper+0.5.0&proto=6
/usr/lib/ruby/1.8/net/http.rb:560:in `initialize': getaddrinfo: Name or
service not known (SocketError)
    from /usr/lib/ruby/1.8/net/http.rb:560:in `open'
    from /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    from /usr/lib/ruby/1.8/timeout.rb:48:in `timeout'
    from /usr/lib/ruby/1.8/timeout.rb:76:in `timeout'
    from /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    from /usr/lib/ruby/1.8/net/http.rb:553:in `do_start'
    from /usr/lib/ruby/1.8/net/http.rb:542:in `start'
    from /usr/lib/ruby/1.8/net/http.rb:1035:in `request'
     ... 7 levels...
    from /usr/bin/rrip_gui:160:in `scan_drive'
    from /usr/bin/rrip_gui:57:in `initialize'
    from /usr/bin/rrip_gui:1093:in `new'
    from /usr/bin/rrip_gui:1093

I think you could solve that, with checking for an internet connection
before you try to get cddb info.

Original issue reported on code.google.com by IPsting...@gmail.com on 22 Jun 2008 at 6:12

GoogleCodeExporter commented 8 years ago
Ok, I guess I should check for a SocketError here. Thanks for testing this :)

Original comment by rubyripp...@gmail.com on 22 Jun 2008 at 9:03

GoogleCodeExporter commented 8 years ago
Fixed in r242.

Original comment by rubyripp...@gmail.com on 10 Jul 2008 at 5:29