pccasto / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Various artists freedb result crash #225

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Use a disc that comes up in FreeDB as various artists
2. hit rip
3. crash

What is the expected output? What do you see instead?
should start ripping but instead:
preparing to contact freedb server
Created query string:
/~cddb/cddb.cgi?cmd=cddb+query+8d0e1f0c+12+150+7529+24142+49199+70563+84175+1109
91+147161+166571+197209+215721+242408+3617&hello=anonymous+my_secret.com+rubyrip
per+0.5.3&proto=6
One hit found; parsing
Created fetch string:
/~cddb/cddb.cgi?cmd=cddb+read+rock+8d0e1f0c&hello=anonymous+my_secret.com+rubyri
pper+0.5.3&proto=6
preparing to contact freedb server
Created query string:
/~cddb/cddb.cgi?cmd=cddb+query+8d0e1f0c+12+150+7529+24142+49199+70563+84175+1109
91+147161+166571+197209+215721+242408+3617&hello=anonymous+my_secret.com+rubyrip
per+0.5.3&proto=6
One hit found; parsing
Created fetch string:
/~cddb/cddb.cgi?cmd=cddb+read+rock+8d0e1f0c&hello=anonymous+my_secret.com+rubyri
pper+0.5.3&proto=6
./rubyripper_gtk2.rb:487:in `save_updates': undefined method `varArtists'
for #<Disc:0xb64009a0>
     from ./rubyripper_gtk2.rb:487:in `times'
     from ./rubyripper_gtk2.rb:487:in `save_updates'
     from ./rubyripper_gtk2.rb:216:in `start_rip'
     from ./rubyripper_gtk2.rb:88:in `create_signals'
     from ./rubyripper_gtk2.rb:1115:in `call'
     from ./rubyripper_gtk2.rb:1115:in `main'
     from ./rubyripper_gtk2.rb:1115

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?
svn291

Please provide any additional information below.
Not really a VA disc but somebody submitted it wrong to FreeDB.

Original issue reported on code.google.com by mordbr...@gmail.com on 7 Aug 2008 at 6:55

GoogleCodeExporter commented 8 years ago
Thanks for catching this one. It's fixed in r293 I think.

Original comment by rubyripp...@gmail.com on 7 Aug 2008 at 7:56

GoogleCodeExporter commented 8 years ago
No crash, but now rr spits out:
/home/usr/src/rubyripper/svn/rr_lib.rb:819:in `checkVarArtist'
and does not continue

Original comment by mordbr...@gmail.com on 7 Aug 2008 at 6:52

GoogleCodeExporter commented 8 years ago
this one is fixed as well already.

Original comment by rubyripp...@gmail.com on 7 Aug 2008 at 8:13

GoogleCodeExporter commented 8 years ago
Excellent, I think that solved it.

Original comment by mordbr...@gmail.com on 7 Aug 2008 at 8:31