pccasto / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

rubyripper crash with 0.5.5 or git if you start the rip (regression) #277

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. insert an audio cd
2. start rubyripper (gui or command line)
3. start to rip the cd

What is the expected output? What do you see instead?
rubyripper crash and I get this:

/home/linux/rubyripper-git/rr_lib.rb:871:in `checkNames': undefined method
`include?' for nil:NilClass
         from /home/linux/rubyripper-git/rr_lib.rb:840:in `initialize'
         from /home/linux/rubyripper-git/rr_lib.rb:1597:in `new'
         from /home/linux/rubyripper-git/rr_lib.rb:1597:in `settingsOk'
         from ./rubyripper_gtk2.rb:221:in `start_rip'
         from ./rubyripper_gtk2.rb:88:in `create_signals'
         from ./rubyripper_gtk2.rb:1126:in `call'
         from ./rubyripper_gtk2.rb:1126:in `main'
         from ./rubyripper_gtk2.rb:1126

1) What version of rubyripper are you using? On what operating system?
0.5.5 and git

2) Are you using the gtk2 or the commandline interface?
both

3) Is the problem gone with the default settings? If so, please attach your
settings file ($HOME/.rubyripper/settings).
-

Please provide any additional information below.
This is an regression, go bach with git to
"056c7cc4ea21e0e568ee7c037e33b3cd261dbe7a" - Preparethe 0.5.4 release and
the bug is gone

Original issue reported on code.google.com by jbuec...@gmail.com on 6 Feb 2009 at 12:46

GoogleCodeExporter commented 8 years ago
It's fine when you decide to use latest git. But after updating you should also 
have
a quick look at git log when you encounter a crash. An alternative is
http://github.com/rubyripperdev/rubyripper/commits/master. 

Git log shows:

----------------------
commit f0e501c68b2a0f13ba83778aeab87e6ccb94cab6
Author: Bouke Woudstra <rubyripperdev@gmail.com>
Date:   Wed Feb 4 23:43:14 2009 +0100

    The clean function is made obsolete by the Output class.

    Notice that the Encode / Ripping class still have to be ported. In
    the meantime Rubyripper won't work.

commit d40314089b0fb99acaf035da61f7fd190431a877
Author: Bouke Woudstra <rubyripperdev@gmail.com>
Date:   Wed Feb 4 23:35:53 2009 +0100

    Further integrate the Output class for Gui_Support and Cuesheet.

commit ea58a4a7f3a632967b4475cac98e104d03f12afa
Author: Bouke Woudstra <rubyripperdev@gmail.com>
Date:   Wed Feb 4 22:57:38 2009 +0100

    Update the README file, FAQ. We use git these days.

commit ff621b1cd76ac152db6044b6ec91a72babd2a7cd
Author: Bouke Woudstra <rubyripperdev@gmail.com>
Date:   Wed Feb 4 22:21:48 2009 +0100

    Clean up the Rubyripper class while we're at it.

    Also some small fixes to support the new Output class.

commit 549c7972dbd39d2ed80ed683c05ab6dd18934d7d
Author: Bouke Woudstra <rubyripperdev@gmail.com>
Date:   Wed Feb 4 21:56:52 2009 +0100

    Further work on the Output class.

    Trying to integrate it with the Rubyripper class for a start. Notice
    that Rubyripper probably won't work very well right now due to all
    the changes.
--------------------

So did you actually test if 0.5.5 worked?

Original comment by rubyripp...@gmail.com on 6 Feb 2009 at 4:21

GoogleCodeExporter commented 8 years ago
This particular crash should be fixed. But as the log shows the Encode + Ripping
class will have references to functions that are removed. So it won't work yet.

Original comment by rubyripp...@gmail.com on 6 Feb 2009 at 9:25