Make %va=%a in non-various mode

[GoogleCodeExporter]

Hello !

I'm using RR 0.5.4 on Ubuntu 08.10, with the audio codec set to "Other" : 

lame -h -V 2 --vbr-new -m s --add-id3v2 --pad-id3v2  --tt "%t" --ta "%a"
--tl "%b" --ty "%y" --tn "%n" --tg "%g" %i "%o.mp3"

If I rip a non various artist CD, this command is working fine. However
with a various artist CD, each file is tagged with the "global" artist of
the CD, because of the --ta "%a" option.

Ok you will say, you just have to change --ta "%a" to --ta "%va". You're
right, each track is now getting the right artist :)
But if I use this command line with a non various artist CD, %va is null
and the file have no author !

So if I rip various artist and non various artist cds, each time I have to
change the command line manually...

One quick fix would be to set %va to %a in non-various artist mode, so we
can stick with one command line.

Thanks in advance !

W.

Original issue reported on code.google.com by wizzim@gmail.com on 14 Feb 2009 at 10:03

[GoogleCodeExporter]

You clearly found a logic shortcoming for other codecs. Well, you see, I never 
use
it. So ideas for improvements are always welcome :)

So let's see if we can find some logic to solve this. Simply changing %va to %a 
would
be a quick hack, but you loose the information of the artist field of the disc.
Perhaps offering a seperate commandline for various artist discs is the most 
simple
option that gives the most flexibility.

Original comment by rubyripp...@gmail.com on 14 Feb 2009 at 10:51

• Changed state: Accepted

[GoogleCodeExporter]

You won't lose any information by setting the same value to %va and %a in non 
various
mode, since %va is empty anyway.

Let's take an example :
Non various cds :
Global Author = A,
=> %va = A and %a = A

Various cd :
Global Author = A, per-track Author = A1, A2, etc..
=> %va=A1 or A2, ... and %a = A

But you're right in a way : to have a separate commandline for non-various cds 
may 
provide more flexibility. However, I fear that the interface become bloated...

It's your call ;)

Original comment by wizzim@gmail.com on 14 Feb 2009 at 11:05

[GoogleCodeExporter]

It's not entirely true the artist field is empty anyway. It's usually filled 
with
Varous Artists or something like that. Also, some codecs have special tags for
various artists. Lame for instance has it too.

Original comment by rubyripp...@gmail.com on 18 Feb 2009 at 4:33

[GoogleCodeExporter]

When following your idea for a hack, it might be confusing for users who want 
to save
the value of %a. Adding another commandline option seems a bit overkill indeed.

You might just want to set your lame settings in the mp3 section directly. Just
replace anything currently there with "-h -V 2 --vbr-new -m s --add-id3v2
--pad-id3v2" (without the quotes).

Otherwise, the way to go is to request native support if your favourite codec 
is not
yet supported.

Original comment by rubyripp...@gmail.com on 15 Apr 2009 at 7:05

• Changed state: WontFix

[GoogleCodeExporter]

Perhaps I didn't understand the issue quite well at first. I am happy to 
announce this 
one is fixed now with commit:
http://github.com/rubyripperdev/rubyripper/commit/22d806408cb74b29a6a5da3239e362
8e6683
9b47

Original comment by boukewou...@gmail.com on 6 Feb 2010 at 12:06

• Changed state: Fixed