Crash when freedb information has no tracks/one empty track

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Insert CD "Schuetz - St. Matthew Passion by Wuertemberg Chamber Choir"
with freedb info enabled.
2. Get a choice between two CD's
3. Choose the second (from misc).
4. RubyRipper crashes.

What is the expected output? What do you see instead?

Expect the program to show track info, not crash.

1) What version of rubyripper are you using? On what operating system?

Version 0.5.5 on Ubuntu Linux 8.10

2) Are you using the gtk2 or the commandline interface?

gtk2 interface.

3) Is the problem gone with the default settings? If so, please attach your
settings file ($HOME/.rubyripper/settings).

Probably not, but didn't try.

Please provide any additional information below.

The freedb query and read urls are:

http://freedb2.org/~cddb/cddb.cgi?cmd=cddb+query+020d2f01+1+150+3377&hello=anony
mous+my_secret.com+rubyripper+0.5.5&proto=6
http://freedb2.org/~cddb/cddb.cgi?cmd=cddb+read+misc+020d2f01&hello=anonymous+my
_secret.com+rubyripper+0.5.5&proto=6

The stack trace is:

/usr/local/lib/site_ruby/1.8/rr_lib.rb:840:in `checkVarArtist': undefined
method `include?' for nil:NilClass (NoMethodError)
    from /usr/local/lib/site_ruby/1.8/rr_lib.rb:839:in `times'
    from /usr/local/lib/site_ruby/1.8/rr_lib.rb:839:in `checkVarArtist'
    from /usr/local/lib/site_ruby/1.8/rr_lib.rb:837:in `each'
    from /usr/local/lib/site_ruby/1.8/rr_lib.rb:837:in `checkVarArtist'
    from /usr/local/lib/site_ruby/1.8/rr_lib.rb:825:in `handleResponse'
    from /usr/local/lib/site_ruby/1.8/rr_lib.rb:745:in `freedbChoice'
    from /usr/bin/rrip_gui:1058:in `initialize'
    from /usr/bin/rrip_gui:1056:in `new'
    from /usr/bin/rrip_gui:1056:in `initialize'
    from /usr/bin/rrip_gui:1118:in `call'
    from /usr/bin/rrip_gui:1118:in `main'
    from /usr/bin/rrip_gui:1118

Original issue reported on code.google.com by hessel...@gmail.com on 8 Mar 2009 at 7:43

[GoogleCodeExporter]

Okay, it seems that this album doesn't have any tracks. So when it checks for
seperators between tracks it fails because the tracklist is empty. Thanks for
providing the links :)

Note to myself -> Build a check to see if the tracklist is empty before calling 
this
function.

Original comment by rubyripp...@gmail.com on 5 Apr 2009 at 2:12

• Changed state: Accepted
• Added labels: Type-Defect
• Removed labels: Type-Enhancement

[GoogleCodeExporter]

This is fixed in latest git. If no trackname is found an empty string is 
returned
instead of nil. Returning nil was the reason of crashing.

Latest git is still unstable however, so you have to wait a while to use it 
yet. I
expect to fix it next week.

Original comment by rubyripp...@gmail.com on 12 Apr 2009 at 12:49

• Changed state: Fixed