pcctc / affirm

Data affirmation and validation
https://pcctc.github.io/affirm/
Other
6 stars 3 forks source link

Custom excel report #33

Closed shannonpileggi closed 11 months ago

shannonpileggi commented 11 months ago

Closes #29 Closes #34

shannonpileggi commented 11 months ago

still wip

shannonpileggi commented 11 months ago

Notes on next to do steps:

shannonpileggi commented 11 months ago

Are there additional unit tests I should add?

Some assumptions I made about the excel report format that a user may want to customize - what do you think? Should I add in some flexibility in this PR, or in another issue?

  1. In the first summary sheet, dropping NA columns that were not submitted as arguments to affirm_.
  2. In the first summary sheet, the column ordering.
  3. In all sheets, min/max defaults for column widths.
  4. In all sheets, the addition of a "Notes" column (and its default column width & placement).
shannonpileggi commented 11 months ago

need to re-think checking on affirmation_name in excel report, doesn't allow something like this: affirmation_name = "{data_frames}{str_pad(id, width = 3, pad = '0')}"

shannonpileggi commented 11 months ago

need to re-think checking on affirmation_name in excel report, doesn't allow something like this: affirmation_name = "{data_frames}{str_pad(id, width = 3, pad = '0')}"

Maybe this can be a separate issue to keep things simpler.