search

pcdshub / Bug-Reports-and-Requests

Issue Tracking for PCDS Software
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Add PP trigger to PP objects, ditto x/y motors. #25

Open silkenelson opened 4 years ago

silkenelson commented 4 years ago

Feature Request I would like to be able to check the trigger settings for the PP triggers. The old PP class in XPP & XCS changes the trigger delay when changing modes and I suppose here that that is/was necessary.

Existing Alternatives None

Context I would like to successfully use the PP and not learn during the shift that the PP let the event through 2 events after the PP trigger code has been sent....

ZLLentz commented 4 years ago

The approach here should probably be to use the Trigger class, adding it as a subdevice of the pulsepicker: https://github.com/pcdshub/pcdsdevices/blob/master/pcdsdevices/evr.py

Then we need to track down the EVR PVs for each pulsepicker and make sure they get passed into happi.

silkenelson commented 4 years ago

Also add x/y motors when we are already working on the PP object.

silkenelson commented 4 years ago

We should also add :SE as the mode read back. Setting a mode takes time, so we should ideally only do that when necessary.