search

pcdshub / Bug-Reports-and-Requests

Issue Tracking for PCDS Software
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

PP.close() stops sequencer #42

Open silkenelson opened 4 years ago

silkenelson commented 4 years ago

Bug Report calling PP.close stope the hutch sequencer

Expected Behavior Should it do that? Investigate why it does this & decide

Context XCS was wonder why they stopped seeing their on/off lasers after they close the PP

Steps To Reproduce

  1. call pp.close() with sequencer running
  2. look at hutch sequencer

Your Environment xcs3

ZLLentz commented 4 years ago

Internally, PulsePicker.close() simply puts to a PV and waits on a PV. See https://github.com/pcdshub/pcdsdevices/blob/637465ed05cdfe7c1da705aa04e3ca58c5239b32/pcdsdevices/pulsepicker.py#L106-L119.

I assume this stops the on/off lasers because it brings us out of flip flop mode.

silkenelson commented 4 years ago

Interesting. XCS does not use flip-flop, we just always have x-rays on, our sequencer only changes the laser-timing. So that is not it.

ZLLentz commented 4 years ago

In that case, I have no explanation. To me it seems like the PVs are completely unrelated. Will require a deeper look.