search

pcdshub / IocManager

pyqt5 + pyca-based EPICS IOC Manager
https://confluence.slac.stanford.edu/display/PCDS/IOC+Manager+for+Users
2 stars 6 forks source link

Let --move use "open" and "closed" for port values #12

Closed mcb64 closed 10 months ago

mcb64 commented 10 months ago

Changed to use the open/closed port selection code for both --add and --move. Also scriptified COMPILE.

mcb64 commented 10 months ago

Seems sensible on the whole. I assume you wanted to ask us for reviews rather than assigning us the PR?

Don't bother me with facts. ;-)

mcb64 commented 10 months ago

So... what's the story with the checks?

tangkong commented 10 months ago

We added check requirements to all our repos, regardless of whether or not the repo actually has tests to run. We can ignore them here, though it remains as a reminder that we should add tests