Closed tangkong closed 5 months ago
I'm going to request help QA'ing this. I'm still isolating and fixing bugs, but maybe another set of eyes will turn up some new bugs to squash
If you still have some known bugs you're squashing, I'll give this ~15mins as a QA and review the actual code later when you've tracked them down.
I didn't find any technical bugs for this PR in my QAing, just some user experience things. In general everything worked as intended and I could see this getting a lot of use for beamline checkouts.
UX stuff related to this PR:
Other discoveries, probably pre-existing conditions:
I actually don't have any current bugs, but just sort of assume that some will pop up as I continue to play around with it 😢
I might address results-propagation and reports in a followup PR. I think it'll be a bit involves and probably deserves a focused look
Maybe I should give this a full code review tomorrow then? I'm currently braining worse than expected with heat + post-race stuff.
Feel free to punt until you have the time. I need to stop looking at ATEF for a bit, starting to reach a state of semantic satiation...
The atef hydra strikes again 🐍
Description
TemplateConfigurationPage
andTemplateRunWidget
for editing and running Template-steps in the atef config gui.TemplateStep
/TemplateConfiguration
into the various "maps" we have littered around the repo.Motivation and Context
In a bit of laziness / DRY, I've used the same pages for both the active and passive checkout cases.
There's a bit of finicky business when it comes to preparing checkouts with template-steps. As is, the step/config fails to prepare if the file is invalid. This will cause the entire page to fail. In my initial formulation this was the proper thing to do, but I'm starting to think it's not transparent enough about its failure mode.
How Has This Been Tested?
Interactively, primarily. I'll be seeing if I can't blow up the test suite by trying to build one of these widgets in CI.
Where Has This Been Documented?
This PR
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page