pcdshub / atef

PCDS Automated Test Execution Framework
https://pcdshub.github.io/atef/
Other
3 stars 10 forks source link

GUI/ENH: add template steps to passive and active checkout GUI #241

Closed tangkong closed 5 months ago

tangkong commented 5 months ago

Description

Motivation and Context

In a bit of laziness / DRY, I've used the same pages for both the active and passive checkout cases.

There's a bit of finicky business when it comes to preparing checkouts with template-steps. As is, the step/config fails to prepare if the file is invalid. This will cause the entire page to fail. In my initial formulation this was the proper thing to do, but I'm starting to think it's not transparent enough about its failure mode.

How Has This Been Tested?

Interactively, primarily. I'll be seeing if I can't blow up the test suite by trying to build one of these widgets in CI.

Where Has This Been Documented?

This PR

image

image

Pre-merge checklist

tangkong commented 5 months ago

I'm going to request help QA'ing this. I'm still isolating and fixing bugs, but maybe another set of eyes will turn up some new bugs to squash

ZLLentz commented 5 months ago

If you still have some known bugs you're squashing, I'll give this ~15mins as a QA and review the actual code later when you've tracked them down.

ZLLentz commented 5 months ago

I didn't find any technical bugs for this PR in my QAing, just some user experience things. In general everything worked as intended and I could see this getting a lot of use for beamline checkouts.

UX stuff related to this PR:

Other discoveries, probably pre-existing conditions:

tangkong commented 5 months ago

I actually don't have any current bugs, but just sort of assume that some will pop up as I continue to play around with it 😢

I might address results-propagation and reports in a followup PR. I think it'll be a bit involves and probably deserves a focused look

ZLLentz commented 5 months ago

Maybe I should give this a full code review tomorrow then? I'm currently braining worse than expected with heat + post-race stuff.

tangkong commented 5 months ago

Feel free to punt until you have the time. I need to stop looking at ATEF for a bit, starting to reach a state of semantic satiation...

tangkong commented 5 months ago

The atef hydra strikes again 🐍