search

pcdshub / atef

PCDS Automated Test Execution Framework
https://pcdshub.github.io/atef/
Other
3 stars 10 forks source link

BLD: rely on matplotlib-base instead of pinning matplotlib <= 3.9 #252

Open tangkong opened 2 weeks ago

tangkong commented 2 weeks ago

Expected Behavior

We shouldn't pin dependencies for extended amounts of time.

Current Behavior

We pin matplotlib

Possible Solution

We should depend on matplotib-base

Steps to Reproduce (for bugs)

N/A

Context

251

Your Environment

pcds-5.8.4, for now

ZLLentz commented 2 weeks ago

Note that this pin creates a warning in the pcds-envs build because somehow I have a matplotlib above 3.9 without the pyside support, which is confusing in itself

tangkong commented 2 weeks ago

This was closed by #251 , as far as atef is concerned.

Is the missing pyside support due to the use of matplotlib-base?

ZLLentz commented 2 weeks ago

Sorry, maybe I should have made a new ticket to track this But what I mean is that anything in requirements.txt is picked up by pip check, so this line gives a warning if a newer matplotlib is installed: https://github.com/pcdshub/atef/blob/ed137620cfd8f411e16fd27a68d806708b61512e/requirements.txt#L11

ZLLentz commented 2 weeks ago

The identity of the missing pyside support is unknown to me, except that the build that the solver picks doesn't require pyside (all the newest builds do)