search

pcdshub / btms-ui

Laser Hall Beam Transport Motion System User Interface
Other
0 stars 4 forks source link

ENH: Add new sources #12

Closed slactjohnson closed 3 months ago

slactjohnson commented 3 months ago

Description

Adds new sources (LS3, LS4, and L6) to the GUI. Adds ability to show/hide the controls for each bay. Adds ability to show/hide the graphics panel for a smaller interface. Cleans up some small GUI issues.

Motivation and Context

Closes #5 Closes #6 Closes #10

How Has This Been Tested?

Tested using the live system in the laser hall.

Where Has This Been Documented?

This PR.

Screenshots:

image

image

slactjohnson commented 3 months ago

This is done, and functional, but waiting for more feedback from the laser group on anything they want to add.

slactjohnson commented 3 months ago

Modified btms-sources.ui to stop compressing the destination combo box.

slactjohnson commented 3 months ago

Updated to show save centroid button during expert mode: image

slactjohnson commented 3 months ago

I'd like to merge this before starting on the homing procedure work. I think there will be merge conflicts otherwise. This is ready for review.

slactjohnson commented 3 months ago

@christina-pino @aberges-SLAC Pinging here again. Please review when you get a chance.

christina-pino commented 3 months ago

Screenshot 2024-07-24 at 6 36 58 PM So far everything looks good and is functional (well without clicking any active buttons). One suggestion I have is to set the right side to be scrollable. The controls get very condensed when all of the sources are open. But this is a feature that can wait and be an issue for later.

slactjohnson commented 3 months ago

@christina-pino That's a good idea. I've added a scroll area to the GUI: image

slactjohnson commented 3 months ago

@christina-pino Sorry, re-requesting review; I added the scroll area you wanted and fixed an alignment issue with the left side sources.