search

pcdshub / btms-ui

Laser Hall Beam Transport Motion System User Interface
Other
0 stars 4 forks source link

ENH: Save nominal confirmation dialog #4

Closed slactjohnson closed 2 months ago

slactjohnson commented 2 months ago

Description

Adds a confirmation dialog to the save nominal positions routine.

Motivation and Context

Closes #3 Closes #7

How Has This Been Tested?

Tested live in the laser hall by saving current settings. Resulting dialogs below:

image

image

slactjohnson commented 2 months ago

@aberges-SLAC now that I've resolved the CI issues, can you give your approval again so I can merge?

slactjohnson commented 2 months ago

@aberges-SLAC Actually, scratch that, I'm just going to add the centroid nominal saving dialog to this PR as well.

slactjohnson commented 2 months ago

@aberges-SLAC @christina-pino this is ready for review again

slactjohnson commented 2 months ago

@aberges-SLAC These methods are ultimately reading PVs that come from the PLC. If a nominal setting has not been configured, we just get 0.0, like in the centroids example. If the PVs are not available, then it should throw an exception.