search

pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 27 forks source link

Rewrite isCam from serverStat! #124

Closed silkenelson closed 2 years ago

silkenelson commented 2 years ago

Expected Behavior

serverStat is supposed to be used to cycle servers as a wrapper on psipmi. It is NOT supposed to fix cameras or tell people to use the iocmanager to reboot servers, if anything, the opposite!

Current Behavior

XPP report this to happen for serverStat yag2 (DAQ camera!): when I try to serverStat is it says “go to the ioc manager to reboot/check status” in the ioc manager I find SB3 - YAG 2 and “noconnect”

Possible Solution

remove the whole isCam section and at the very least, don't have it find things that also actively exist in the DAQ cnf file

ZryletTC commented 2 years ago

Are you saying we should remove all cnf functionality or that we should look at the cnf for devices not to touch?

silkenelson commented 2 years ago

What I meant to say is that serverStat uses netconfig and the cnf files to look for device to powercycle. We then also added some functionality for PV (though inherently, this could also be achieved via the iocmanager). isCam added some functionality for cameras that I'm not sure really belongs in here at all, but at the very least, we should NOT run isCam before we figure out if a device is in the DAQ. I'd be interested in arguments for what serverStat should really do with camera arguments that are not DAQ devices: I find it rather rare that the problem is the server and if people believe it's the server, all the script is to tell you to use the iocmanager to powercycle. Then it also uses the gige script to reboot the IOC, restart acquisition, ... which are functions that I do not believe belong here. I'm somewhat open to discussions, but please keep in mind that we are not trying to rewrite launch-control!