search

pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 27 forks source link

fix(set_gem_timing): updated logic to reflect application layer concers: do not exit the program if PV and IOC software are out of sync #164

Closed joshc-slac closed 1 year ago

joshc-slac commented 1 year ago

Description

Addressing the valid concern in the set_gem_timing script that we want to guard against the edge case where PV: KFE:CAM:TPR:02:MODE is inconsistent with IOC software path.

For reference here is the intended pairing: KFE:CAM:TPR:02:MODE Value IOC Software Path
SC ioc/fee/GasDetDAQ/R4.0.22-NOTS
NC ioc/fee/GasDetDAQ/R4.0.22

Critical functional change is that if an operator tries to run set_gem_timing into a mode in which the PV: KFE:CAM:TPR:02:MODE already is in it will not terminate the program.

Motivation and Context

https://github.com/pcdshub/engineering_tools/pull/163#discussion_r1320381287

How Has This Been Tested?

Where Has This Been Documented?

Code comment and output of command