search

pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 27 forks source link

Kinit helper #169

Closed KaushikMalapati closed 1 year ago

KaushikMalapati commented 1 year ago

Description

Adds two functions kauth and afsauth, which will create kerberos and afs tokens respectively. afsauth will call kauth. afsauth is called if the script is run, functions are accessible by sourcing.

Motivation and Context

147

How Has This Been Tested?

shellcheck, running the script, and sourcing and trying functions individually and checking that tokens are created with klist and tokens or that correct error message is printed.

Where Has This Been Documented?

Code is commented

KaushikMalapati commented 1 year ago

Thanks for the feedback; I added renewing to kauth and changed the comment about psbuild. Is there a way to update a pr other than by adding more commits? Not sure if there's something more convenient I can do so that a reviewer only sees the newest part.

ZLLentz commented 1 year ago

Reviewers can actually get a diff view of only the new changes since the last review, and they can also look at individual commits if they want to. Your changes look good to me, let me give this a try myself before putting out the approval again

ZLLentz commented 1 year ago

One final thing: I completely forgot about the repo README (I should have brought that up earlier). If you add an entry to that for this script we're good to go.