pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 27 forks source link

MNT/STY/TST: Add pre-commit hooks, CI job, standardize style #183

Closed tangkong closed 7 months ago

tangkong commented 7 months ago

Description

Motivation and Context

The style is whack.

Shellcheck is a much larger effort, and one that we should be careful with. We'll have to go through those more carefully, but for now the CI will only check diff'd files

I spent way too much time trying to grab specific sha's for pre-commit's --from-ref and --to-ref arguments, but the location of that information in the github payload was inconsistent between push and pull-request. At that point I figured I should just get it working.

How Has This Been Tested?

Pre-commit vomits all over my terminal repeatedly

Where Has This Been Documented?

This PR