pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 26 forks source link

ENH: allow in-script tagging in ioc-deploy #200

Closed ZLLentz closed 2 months ago

ZLLentz commented 2 months ago

Description

Main goal: allow us to make releases from the command line without going to the github website, for convenience

Main changes:

Other things to note:

I also snuck some smaller changes into here

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-6035

For releasing hutch-specific templated IOCs that amount to version bumps, etc., people have expressed that they find it annoying to open up github and do by hand what in the past they had done all in the command-line, so I provide these features here.

This isn't so necessary or useful for when you're already on github doing a code review process.

How Has This Been Tested?

Interactively only

Where Has This Been Documented?

Added to the help text and readme

ZLLentz commented 2 months ago

The diff here still shows the variant from before the other PR was merged, I'll see if closing and re-opening fixes it

ZLLentz commented 2 months ago

It worked, now with the updated diff I'll have an easier time writing the description and the reviews will be simpler later too.

ZLLentz commented 2 months ago

This is likely the last ioc-deploy PR for a while unless new bugs are found

ZLLentz commented 2 months ago

One more re-check from me that the main code paths work after the minor adjustments and then I'm clicking merge!