pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 26 forks source link

Revise checks for opr users #206

Open ZLLentz opened 1 month ago

ZLLentz commented 1 month ago

Expected Behavior

Checks for operator users should only find operator users.

Current Behavior

Most checks are implemented via checking if the username contains "opr", which will give false positives for some (rare) users.

Possible Solution

Check specifically for the hutch operator accounts in /cds/home/opr instead:

$ ls /cds/home/opr
cxiopr  detopr  feeopr  hplopr  lasopr  mccopr  mecopr  mfxopr  rixopr  tmoopr  tstopr  txiopr  uedopr  xcsopr  xppopr

Context

https://github.com/pcdshub/engineering_tools/pull/204#discussion_r1783186408