search

pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 26 forks source link

Revise hard-coded paths to the engineering_tools deploy directory from within engineering_tools #207

Open ZLLentz opened 1 month ago

ZLLentz commented 1 month ago

Expected Behavior

All scripts in engineering_tools that need to run another script in engineering_tools should run the script in the same release directory, so that we can isolate version-specific behavior and test/deploy more easily.

Current Behavior

Some scripts reference the specific release directory directly: https://github.com/pcdshub/engineering_tools/blob/953c167e0701756b8ff41da1362e1a2b2cb525e4/scripts/set_gem_timing#L31

Possible Solution

Use any of the various bash-isms for getting the current directory of a shell script.

Context

https://github.com/pcdshub/engineering_tools/pull/204#discussion_r1783235437