pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 27 forks source link

Fix subprocess output not stripped #211

Closed monarin closed 1 month ago

monarin commented 1 month ago

Description

The refactoring of call_subprocess missed stripping out leading and trailing whitespace. This caused get_info --gethutch called to return invalid hutch name.

Motivation and Context

This is a new issue found after the software was deployed. Unfortunately, it was not caught earlier. Reason is unknown at the moment.

A name-validation check using the string length for the hutches was added. This raises ValueError from daqutils inhibiting execution of the codes that follow.

How Has This Been Tested?

Both tmo and rix have been tested.

Where Has This Been Documented?